localspook wrote: > But (e.g.) clang-tidy also supports plugins and so changing the AST matcher > behavior means it may link but behave in a surprising manner.
In theory, someone could be relying on this behavior. On the other hand, no check in clang-tidy was, and the previous behavior was the root cause of two bugs, so you could argue this change has more potential to fix downstream code. > if a release manager or someone else has concerns, I think it's also fine to > not backport (nothing seems to be on fire, at least unless I've missed > something). Agreed, it's not a critical change. And if it doesn't go in, we can always backport targeted workarounds in the affected checks (wrap the matchers in `traverse(TK_IgnoreUnlessSpelledInSource, ...)`). https://github.com/llvm/llvm-project/pull/184039 _______________________________________________ llvm-branch-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
