adit4443ya wrote:

Hello @bassiounix 
I want to start to make contributions in LLVM. I came across this issue #147386 
and saw this PR. I made similar changes for refactoring `ffmaf128`. Can you 
provide me exact steps as how to test it locally before making PR? 
For now I tested with 

```
cmake -G Ninja -S runtimes -B build-libc \
  -DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++ \
  -DCMAKE_BUILD_TYPE=Debug -DLLVM_ENABLE_RUNTIMES="libc" 
-DLLVM_LIBC_FULL_BUILD=ON
ninja -C build-libc libc.src.math.ffmaf128
```
And it passed relevant tests. Is this correct direction?

https://github.com/llvm/llvm-project/pull/163977
_______________________________________________
llvm-branch-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

Reply via email to