jrtc27 wrote: > Thanks for cleaning up my ugly https://reviews.llvm.org/D100490 in the > previous commits :) > > I think having names for the boolean parameters makes the code calling this > function easier to read than a magic true/false. So I'd have a slight > preference for keeping an enum parameter but I'll leave that decision to > @MaskRay.
There's always /*isAgainstSymbol=*/ if you want to name it, I suppose. The existence of the enum just encourages people to do things like MIPS and Morello have both done in the past, so I want to make sure that everything ends up being done via RelExpr instead. https://github.com/llvm/llvm-project/pull/150813 _______________________________________________ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
