https://github.com/banach-space commented:
Great work, Momchil - thank you! I've left a number of comments, but nothing major. My main high-level suggestion is to follow the guidance in [MLIR's Testing Guide](https://mlir.llvm.org/getting_started/TestingGuide/#contributor-guidelines) a bit more closely. It’s a relatively new (and long!) document, so I’ve included specific in-line suggestions to make it easier to see where things could align better. For additional context, this [RFC](https://discourse.llvm.org/t/rfc-should-we-aim-for-more-consistency-in-tests/) provides some of the rationale behind that approach. Also - what about memrefs with dynamic dimensions? https://github.com/llvm/llvm-project/pull/143146 _______________________________________________ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
