https://github.com/banach-space approved this pull request.

Thanks, it's great to see more tests for `i8mm`. The documentation makes it 
relatively easy to follow (despite this being fairly complex!) - that's much 
appreciated!

Overall LGTM, but I have one request. Could you unify the input data between 
SVE and NEON? I am happy for actual code to be duplicated. 

Btw, could you share how you generated the expected output? If that's some 
short numpy snippet, could you include it for future reference? (should these 
tests start to fail)

Thank you!

https://github.com/llvm/llvm-project/pull/144699
_______________________________________________
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

Reply via email to