pcc wrote:

> This needs a caveat somewhere (either in printed usage message or in a 
> comment) that this won't work for local linkage symbols (I suppose the user 
> could give the "file:" prefix but that won't work if 
> -funique-internal-linkage-names was specified etc).

I'm not sure that is worth it. The intent is that users of these development 
tools will refer to the source code. And if you read the source code you'll see 
the function name `getGUIDAssumingExternalLinkage` which tells you what you 
need to know.

> Can you also add a test?

Done.

https://github.com/llvm/llvm-project/pull/143992
_______________________________________________
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

Reply via email to