ilovepi wrote:

@nikic I spent some time over the weekend looking at this, I think if we want 
to avoid cloning the module, we'd need to record enough metadata to recover the 
old state. For the Vtable I think that's not too much data, but IDK about the 
rest. That said, that whole approach seems awfully invasive to the pass and is 
likely to be both buggy and brittle.  I just don't see a good way for us to 
roll back those changes to the VTable otherwise...

Should we just land this for now, and try to come up with something 
better/different as a follow up?

https://github.com/llvm/llvm-project/pull/139999
_______________________________________________
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

Reply via email to