================ @@ -3075,9 +3115,6 @@ convertOmpCancel(omp::CancelOp op, llvm::IRBuilderBase &builder, llvm::OpenMPIRBuilder::LocationDescription ompLoc(builder); llvm::OpenMPIRBuilder *ompBuilder = moduleTranslation.getOpenMPBuilder(); - if (failed(checkImplementationStatus(*op.getOperation()))) - return failure(); - ---------------- skatrak wrote:
Nit: Even if all clauses for the operation are already supported, I think we should still call `checkImplementationStatus()`. It succeeds by default for operations that don't have explicit checks, and it makes adding new checks whenever unsupported operands are introduced easier later on. https://github.com/llvm/llvm-project/pull/137841 _______________________________________________ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
