paschalis-mpeis wrote:

Yeap, good idea. I could add `XFAIL` and modify runline like:

```
# RUN: link_fdata %s %t %t.patplt PREAGGPLT --synthetic --nmtool=llvm-nm
```

The differences would be :
- with `REQUIRES` we won't cross-run this x86 lit test on AArch64 (as I do 
currently in ` #137831`)
- with `XFAIL` + `llvm-nm` the test would be expected to fail on both 
architectures. But once your work is merged, it would unexpectedly pass, which 
would break the test and prompt us to update it

---

I'm happy to proceed with this as well.

https://github.com/llvm/llvm-project/pull/135867
_______________________________________________
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

Reply via email to