================
@@ -2233,8 +2235,17 @@ ParseStatus
RISCVAsmParser::parseOperandWithSpecifier(OperandVector &Operands) {
SMLoc S = getLoc();
SMLoc E;
- if (!parseOptionalToken(AsmToken::Percent) ||
- getLexer().getKind() != AsmToken::Identifier)
+ if (!parseOptionalToken(AsmToken::Percent))
+ return Error(getLoc(), "expected '%' relocation specifier");
+ const MCExpr *Expr = nullptr;
+ bool Failed = parseExprWithSpecifier(Expr, E);
+ if (!Failed)
+ Operands.push_back(RISCVOperand::createImm(Expr, S, E, isRV64()));
+ return Failed;
+}
+
+bool RISCVAsmParser::parseExprWithSpecifier(const MCExpr *&Res, SMLoc &E) {
----------------
MaskRay wrote:
As I understand it, `ParseStatus` is preferred for `parse*` functions generated
by TableGen.
However, `ParseStatus` is used very lightly in AsmParser.cpp, where
`parseDataExpr` is needed. So the bool return value here should be ok.
https://github.com/llvm/llvm-project/pull/132569
_______________________________________________
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
