https://github.com/delcypher approved this pull request.

Thanks for explaining the purpose.

Regarding the "more easily see why we crashed." please be aware [I have a GSoC 
proposal to basically do 
this](https://discourse.llvm.org/t/clang-gsoc-2025-usability-improvements-for-trapping-undefined-behavior-sanitizer/84568)
 using the `createTrapFailureMessageFor`. So if possible please don't tackle 
what I describe in the proposal before a GSoC student has had a chance to do 
this. To be clear what you've done in this PR is different from I'm proposing 
so they don't conflict.

Also

* Please give a chance for Clang Debug Info contributors to look over this (CC 
@adrian-prantl) before landing this.
* When possible add as reviewers previous people who worked on the code. In 
this particular case I believe this was @ahatanak 

https://github.com/llvm/llvm-project/pull/128977
_______________________________________________
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

Reply via email to