================ @@ -15,16 +15,21 @@ #include "clang/AST/APValue.h" #include "clang/Basic/DiagnosticLex.h" +#include "clang/Basic/DiagnosticParse.h" #include "clang/Lex/LiteralSupport.h" #include "clang/Lex/Preprocessor.h" #include "llvm/ADT/SmallVector.h" #include "llvm/ADT/StringRef.h" #include "llvm/ADT/StringSwitch.h" +#include "llvm/Frontend/HLSL/HLSLRootSignature.h" + namespace clang { namespace hlsl { +namespace rs = llvm::hlsl::root_signature; ---------------- bogner wrote:
I'm not convinced the brevity this affords later is really worth it, and since this is in a public header it introduces `llvm::hlsl::rs` into far more scopes than just this file, which IMO is just a recipe for confusion. https://github.com/llvm/llvm-project/pull/122982 _______________________________________________ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits