artempyanykh wrote:

> nit: Perhaps 'Common' is a better word than 'Global'. Global made me think of 
> global variables but I realized in the patch that is not what you are doing. 
> Seems you are just creating debug info based on the original function and 
> sharing that with the continuations / splits? Or perhaps just 'CoroDebugInfo'?

Good call @TylerNowicki! I like 'common', updated the stack accordingly. 

It was originally "global" in a sense that it was owned by a module (global) 
rather than the function (local) and so didn't have to be cloned as part of 
function cloning. But I agree that it can be confusing this way.

https://github.com/llvm/llvm-project/pull/118628
_______________________________________________
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

Reply via email to