Meinersbur wrote:

Removed the library name (`flang_rt`, `CufRuntime`) from the include paths and 
put the CufRuntime file into a CUDA subdirectory.

IMHO this violates the basic convention that when including a header file, the 
path indicates what library you will have to link to. E.g. with `#include 
<llvm/Support/Base64.h>`, you will have to link to `-lLLVMSupport`.

https://github.com/llvm/llvm-project/pull/110298
_______________________________________________
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
  • [... Valentin Clement バレンタイン クレメン via llvm-branch-commits
  • [... Valentin Clement バレンタイン クレメン via llvm-branch-commits
  • [... Michael Kruse via llvm-branch-commits
  • [... Michael Kruse via llvm-branch-commits
  • [... Peter Klausler via llvm-branch-commits
  • [... Valentin Clement バレンタイン クレメン via llvm-branch-commits
  • [... Valentin Clement バレンタイン クレメン via llvm-branch-commits
  • [... Valentin Clement バレンタイン クレメン via llvm-branch-commits
  • [... Valentin Clement バレンタイン クレメン via llvm-branch-commits
  • [... Valentin Clement バレンタイン クレメン via llvm-branch-commits
  • [... Michael Kruse via llvm-branch-commits

Reply via email to