rorth wrote: > Hi, since we are wrapping up LLVM 19.1.0 we are very strict with the fixes we > pick at this point. Can you please respond to the following questions to help > me understand if this has to be included in the final release or not.
I guess it's best for @petrhosek to make the final assessment. That said... > Is this PR a fix for a regression or a critical issue? ... it's not a regression but a long(er)-standing bug. Critical? Probably not. > What is the risk of accepting this into the release branch? > > What is the risk of NOT accepting this into the release branch? Although this has been on `main` for a couple of days now without complaint, I'd say it's safer to delay to a later 19.x.0 release at this point. https://github.com/llvm/llvm-project/pull/107362 _______________________________________________ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
