llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT--> @llvm/pr-subscribers-pgo Author: Amir Ayupov (aaupov) <details> <summary>Changes</summary> Pass `ProbeNode` parameter of `trackInlineesOptimizedAway` as const reference. --- Full diff: https://github.com/llvm/llvm-project/pull/102787.diff 3 Files Affected: - (modified) llvm/include/llvm/MC/MCPseudoProbe.h (+1) - (modified) llvm/tools/llvm-profgen/ProfiledBinary.cpp (+2-1) - (modified) llvm/tools/llvm-profgen/ProfiledBinary.h (+4-3) ``````````diff diff --git a/llvm/include/llvm/MC/MCPseudoProbe.h b/llvm/include/llvm/MC/MCPseudoProbe.h index b42bbf2057f161..5c536a8ec0b551 100644 --- a/llvm/include/llvm/MC/MCPseudoProbe.h +++ b/llvm/include/llvm/MC/MCPseudoProbe.h @@ -241,6 +241,7 @@ class MCPseudoProbeInlineTreeBase { InlinedProbeTreeMap &getChildren() { return Children; } const InlinedProbeTreeMap &getChildren() const { return Children; } std::vector<ProbeType> &getProbes() { return Probes; } + const std::vector<ProbeType> &getProbes() const { return Probes; } void addProbes(ProbeType Probe) { Probes.push_back(Probe); } // Caller node of the inline site MCPseudoProbeInlineTreeBase<ProbeType, DerivedProbeInlineTreeType> *Parent = diff --git a/llvm/tools/llvm-profgen/ProfiledBinary.cpp b/llvm/tools/llvm-profgen/ProfiledBinary.cpp index 632ddc7b50f54a..574a9c9f52bf18 100644 --- a/llvm/tools/llvm-profgen/ProfiledBinary.cpp +++ b/llvm/tools/llvm-profgen/ProfiledBinary.cpp @@ -137,7 +137,8 @@ void BinarySizeContextTracker::trackInlineesOptimizedAway( void BinarySizeContextTracker::trackInlineesOptimizedAway( MCPseudoProbeDecoder &ProbeDecoder, - MCDecodedPseudoProbeInlineTree &ProbeNode, ProbeFrameStack &ProbeContext) { + const MCDecodedPseudoProbeInlineTree &ProbeNode, + ProbeFrameStack &ProbeContext) { StringRef FuncName = ProbeDecoder.getFuncDescForGUID(ProbeNode.Guid)->FuncName; ProbeContext.emplace_back(FuncName, 0); diff --git a/llvm/tools/llvm-profgen/ProfiledBinary.h b/llvm/tools/llvm-profgen/ProfiledBinary.h index f2eeca45454592..0588cb48b2af62 100644 --- a/llvm/tools/llvm-profgen/ProfiledBinary.h +++ b/llvm/tools/llvm-profgen/ProfiledBinary.h @@ -167,9 +167,10 @@ class BinarySizeContextTracker { void trackInlineesOptimizedAway(MCPseudoProbeDecoder &ProbeDecoder); using ProbeFrameStack = SmallVector<std::pair<StringRef, uint32_t>>; - void trackInlineesOptimizedAway(MCPseudoProbeDecoder &ProbeDecoder, - MCDecodedPseudoProbeInlineTree &ProbeNode, - ProbeFrameStack &Context); + void + trackInlineesOptimizedAway(MCPseudoProbeDecoder &ProbeDecoder, + const MCDecodedPseudoProbeInlineTree &ProbeNode, + ProbeFrameStack &Context); void dump() { RootContext.dumpTree(); } `````````` </details> https://github.com/llvm/llvm-project/pull/102787 _______________________________________________ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
