================
@@ -45,6 +45,8 @@ namespace opts {
 
 extern cl::opt<bool> TimeRewrite;
 extern cl::OptionCategory BoltOptCategory;
+extern cl::opt<unsigned> Verbosity;
+extern cl::opt<bool> ProfileUsePseudoProbes;
----------------
aaupov wrote:

> The profile (not stale matching) is clearly using probe as probe exists in 
> profile

But in a similar way, the profile can contain BB hashes, but they won't be used 
unless `-infer-stale-profile` is set. (We produce them unconditionally so 
there's no corresponding generation flag).

There's no use of probes outside stale matching.

The confusion argument for me is flipped – if there were separate flags for 
generation and consumption for probes. It's as if we had 
`ProfileEmitDFSIndices` and `ProfileAssumeDFSIndices` instead of 
`ProfileUseDFS` which covers both.

https://github.com/llvm/llvm-project/pull/99891
_______________________________________________
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

Reply via email to