llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT--> @llvm/pr-subscribers-debuginfo Author: Matt Arsenault (arsenm) <details> <summary>Changes</summary> I don't see the point of this check and SelectionDAG does not perform it. In the normal usecase, if there's no debug info the debug intrinsics would not be there in the first place. --- Full diff: https://github.com/llvm/llvm-project/pull/100353.diff 1 Files Affected: - (modified) llvm/lib/CodeGen/SelectionDAG/FastISel.cpp (-16) ``````````diff diff --git a/llvm/lib/CodeGen/SelectionDAG/FastISel.cpp b/llvm/lib/CodeGen/SelectionDAG/FastISel.cpp index ef9f783355190..e255bbaa92b16 100644 --- a/llvm/lib/CodeGen/SelectionDAG/FastISel.cpp +++ b/llvm/lib/CodeGen/SelectionDAG/FastISel.cpp @@ -1203,11 +1203,6 @@ void FastISel::handleDbgInfo(const Instruction *II) { if (DbgLabelRecord *DLR = dyn_cast<DbgLabelRecord>(&DR)) { assert(DLR->getLabel() && "Missing label"); - if (!FuncInfo.MF->getMMI().hasDebugInfo()) { - LLVM_DEBUG(dbgs() << "Dropping debug info for " << *DLR << "\n"); - continue; - } - BuildMI(*FuncInfo.MBB, FuncInfo.InsertPt, DLR->getDebugLoc(), TII.get(TargetOpcode::DBG_LABEL)) .addMetadata(DLR->getLabel()); @@ -1402,12 +1397,6 @@ bool FastISel::selectIntrinsicCall(const IntrinsicInst *II) { case Intrinsic::dbg_declare: { const DbgDeclareInst *DI = cast<DbgDeclareInst>(II); assert(DI->getVariable() && "Missing variable"); - if (!FuncInfo.MF->getMMI().hasDebugInfo()) { - LLVM_DEBUG(dbgs() << "Dropping debug info for " << *DI - << " (!hasDebugInfo)\n"); - return true; - } - if (FuncInfo.PreprocessedDbgDeclares.contains(DI)) return true; @@ -1446,11 +1435,6 @@ bool FastISel::selectIntrinsicCall(const IntrinsicInst *II) { case Intrinsic::dbg_label: { const DbgLabelInst *DI = cast<DbgLabelInst>(II); assert(DI->getLabel() && "Missing label"); - if (!FuncInfo.MF->getMMI().hasDebugInfo()) { - LLVM_DEBUG(dbgs() << "Dropping debug info for " << *DI << "\n"); - return true; - } - BuildMI(*FuncInfo.MBB, FuncInfo.InsertPt, MIMD, TII.get(TargetOpcode::DBG_LABEL)).addMetadata(DI->getLabel()); return true; `````````` </details> https://github.com/llvm/llvm-project/pull/100353 _______________________________________________ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
