llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT--> @llvm/pr-subscribers-flang-fir-hlfir Author: Sergio Afonso (skatrak) <details> <summary>Changes</summary> This patch removes the `outerCombined` argument from `genTargetOp()` and the `processReduction` argument from `genTargetClauses()`, as they aren't used. --- Full diff: https://github.com/llvm/llvm-project/pull/97564.diff 1 Files Affected: - (modified) flang/lib/Lower/OpenMP/OpenMP.cpp (+6-8) ``````````diff diff --git a/flang/lib/Lower/OpenMP/OpenMP.cpp b/flang/lib/Lower/OpenMP/OpenMP.cpp index d8679fb693659..0d456dde630e2 100644 --- a/flang/lib/Lower/OpenMP/OpenMP.cpp +++ b/flang/lib/Lower/OpenMP/OpenMP.cpp @@ -1134,7 +1134,7 @@ static void genSingleClauses(lower::AbstractConverter &converter, static void genTargetClauses( lower::AbstractConverter &converter, semantics::SemanticsContext &semaCtx, lower::StatementContext &stmtCtx, const List<Clause> &clauses, - mlir::Location loc, bool processHostOnlyClauses, bool processReduction, + mlir::Location loc, bool processHostOnlyClauses, mlir::omp::TargetClauseOps &clauseOps, llvm::SmallVectorImpl<const semantics::Symbol *> &mapSyms, llvm::SmallVectorImpl<mlir::Location> &mapLocs, @@ -1676,7 +1676,7 @@ static mlir::omp::TargetOp genTargetOp(lower::AbstractConverter &converter, lower::SymMap &symTable, semantics::SemanticsContext &semaCtx, lower::pft::Evaluation &eval, mlir::Location loc, const ConstructQueue &queue, - ConstructQueue::iterator item, bool outerCombined = false) { + ConstructQueue::iterator item) { fir::FirOpBuilder &firOpBuilder = converter.getFirOpBuilder(); lower::StatementContext stmtCtx; @@ -1690,10 +1690,9 @@ genTargetOp(lower::AbstractConverter &converter, lower::SymMap &symTable, llvm::SmallVector<mlir::Location> mapLocs, devicePtrLocs, deviceAddrLocs; llvm::SmallVector<mlir::Type> mapTypes, devicePtrTypes, deviceAddrTypes; genTargetClauses(converter, semaCtx, stmtCtx, item->clauses, loc, - processHostOnlyClauses, /*processReduction=*/outerCombined, - clauseOps, mapSyms, mapLocs, mapTypes, deviceAddrSyms, - deviceAddrLocs, deviceAddrTypes, devicePtrSyms, - devicePtrLocs, devicePtrTypes); + processHostOnlyClauses, clauseOps, mapSyms, mapLocs, + mapTypes, deviceAddrSyms, deviceAddrLocs, deviceAddrTypes, + devicePtrSyms, devicePtrLocs, devicePtrTypes); llvm::SmallVector<const semantics::Symbol *> privateSyms; DataSharingProcessor dsp(converter, semaCtx, item->clauses, eval, @@ -2099,8 +2098,7 @@ static void genOMPDispatch(lower::AbstractConverter &converter, genSingleOp(converter, symTable, semaCtx, eval, loc, queue, item); break; case llvm::omp::Directive::OMPD_target: - genTargetOp(converter, symTable, semaCtx, eval, loc, queue, item, - /*outerCombined=*/false); + genTargetOp(converter, symTable, semaCtx, eval, loc, queue, item); break; case llvm::omp::Directive::OMPD_target_data: genTargetDataOp(converter, symTable, semaCtx, eval, loc, queue, item); `````````` </details> https://github.com/llvm/llvm-project/pull/97564 _______________________________________________ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
