illwieckz wrote:

> We made a change recently that made the dynamic_hsa version the default. The 
> error you're seeing is from an old HSA, so if you're overriding the default 
> to use an old library that's probably not worth working around.

The error I see comes from the fact there is no old HSA around to workaround an 
LLVM bug.

There is no `hsa/hsa.h` in the tree, the default `dynamic_hsa` is not used.

The `hsa/hsa.h` file is from ROCm, not from LLVM.

Without such patch, LLVM requires ROCm to be installed and configured to be in 
default includes for `src/rtl.cpp` to build if `hsa.cpp` is not built.

This patch is to make LLVM use `dynamic_hsa` for building `src/rtl.cpp` because 
it is the default.

This patch is needed to build both `release/17.x` and `release/18.x`, the 
`main` branch changed the code layout so the patch will not work.

I assume a full LLVM build will not trigger the build problem because something 
else will include `dynamic_hsa` and will make it findable by `src/rtl.cpp` by 
luck. But when building a not-full LLVM, just what's needed by some 
applications, `dynamic_hsa` is not added to the include directories while being 
required by `src/rtl.cpp`.

https://github.com/llvm/llvm-project/pull/95484
_______________________________________________
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

Reply via email to