================ @@ -938,6 +938,11 @@ class CodeGenModule : public CodeGenTypeCache { // Return the function body address of the given function. llvm::Constant *GetFunctionStart(const ValueDecl *Decl); + llvm::Constant *getConstantSignedPointer(llvm::Constant *Pointer, + unsigned Key, + llvm::Constant *StorageAddress, + llvm::Constant *ExtraDiscrim); ---------------- kovdan01 wrote:
Here, this is called `ExtraDiscrim`, in clang/lib/CodeGen/CGPointerAuth.cpp - `OtherDiscriminator`. I suppose that for exact same function its argument names should be the same in the declaration and the definition. I actually suggest to unify this naming all over the pauth-related changes - having one term for a thing is better than mixing several ones for ease of understanding and also helps grepping. Or do I miss smth and extra discriminator is somehow different from other discriminator? https://github.com/llvm/llvm-project/pull/93904 _______________________________________________ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits