https://github.com/kovdan01 commented:
LGTM with a few const-related comments left (actually I've unresolved several previously opened threads). I highly encourage everyone else interested to also look through since while the changes look reasonable and the code does what it's intended to do, there might be some corner cases I've missed or other room for enhancement. @ahmedbougacha Do I miss some reason why const qualifier should not be applied to pointers/references I've mentioned? Even though it might be obvious for experienced llvm contributors that these values are not modified, it's still IMHO better to explicitly mark them as const so a person not so experienced in this area would not have to guess while reading the code whether the non-const-qualified value intended to be modified when passed somewhere by pointer/reference or not. https://github.com/llvm/llvm-project/pull/85736 _______________________________________________ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
