================ @@ -115,8 +115,7 @@ class ClauseProcessor { bool processMap( mlir::Location currentLocation, Fortran::lower::StatementContext &stmtCtx, mlir::omp::MapClauseOps &result, - llvm::SmallVectorImpl<const Fortran::semantics::Symbol *> *mapSyms = - nullptr, + llvm::SmallVectorImpl<const Fortran::semantics::Symbol *> *mapSyms, ---------------- skatrak wrote:
I agree it doesn't look great, but in my opinion it's better to do this than to force the caller to pass an output list even when it won't use it because it's needed internally. Maybe we'll be able to improve things later as we keep developing this. https://github.com/llvm/llvm-project/pull/82853 _______________________________________________ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits