https://github.com/tstellar updated
https://github.com/llvm/llvm-project/pull/79836
>From 01d7ece20a46cec1bc1ef512d9961ee134ca73bd Mon Sep 17 00:00:00 2001
From: Tom Stellard <tstel...@redhat.com>
Date: Mon, 29 Jan 2024 06:30:22 -0800
Subject: [PATCH] [workflows] Fix argument passing in abi-dump jobs (#79658)
This was broken by 859e6aa1008b80d9b10657bac37822a32ee14a23, which added
quotes around the EXTRA_ARGS variable.
---
.github/workflows/llvm-tests.yml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/.github/workflows/llvm-tests.yml b/.github/workflows/llvm-tests.yml
index 63f0f3abfd70a5b..127628d76f1913f 100644
--- a/.github/workflows/llvm-tests.yml
+++ b/.github/workflows/llvm-tests.yml
@@ -125,7 +125,7 @@ jobs:
else
touch llvm.symbols
fi
- abi-dumper "$EXTRA_ARGS" -lver ${{ matrix.ref }} -skip-cxx
-public-headers ./install/include/${{ needs.abi-dump-setup.outputs.ABI_HEADERS
}} -o ${{ matrix.ref }}.abi ./install/lib/libLLVM.so
+ abi-dumper $EXTRA_ARGS -lver ${{ matrix.ref }} -skip-cxx
-public-headers ./install/include/${{ needs.abi-dump-setup.outputs.ABI_HEADERS
}} -o ${{ matrix.ref }}.abi ./install/lib/libLLVM.so
# Remove symbol versioning from dumps, so we can compare across
major versions.
sed -i 's/LLVM_${{ matrix.llvm_version_major }}/LLVM_NOVERSION/' ${{
matrix.ref }}.abi
- name: Upload ABI file
@@ -175,7 +175,7 @@ jobs:
# FIXME: Reading of gzip'd abi files on the GitHub runners stop
# working some time in March of 2021, likely due to a change in the
# runner's environment.
- abi-compliance-checker "$EXTRA_ARGS" -l libLLVM.so -old
build-baseline/*.abi -new build-latest/*.abi || test "${{
needs.abi-dump-setup.outputs.ABI_HEADERS }}" = "llvm-c"
+ abi-compliance-checker $EXTRA_ARGS -l libLLVM.so -old
build-baseline/*.abi -new build-latest/*.abi || test "${{
needs.abi-dump-setup.outputs.ABI_HEADERS }}" = "llvm-c"
- name: Upload ABI Comparison
if: always()
uses: actions/upload-artifact@v3
_______________________________________________
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
