Author: Tom Stellard Date: 2023-11-24T08:42:42+01:00 New Revision: e957e6dcb29d94e4e1678da9829b77009be88926
URL: https://github.com/llvm/llvm-project/commit/e957e6dcb29d94e4e1678da9829b77009be88926 DIFF: https://github.com/llvm/llvm-project/commit/e957e6dcb29d94e4e1678da9829b77009be88926.diff LOG: [runtimes] Add missing test dependencies to check-all (#72955) The test-depends target contained all the dependencies needed to run the runtimes tests, but it was never added as a dependency of check-all. This caused some of the tsan tests to fail, since the custom libcxx build the tests were looking for was never built. Besides the tsan failures, this fixes all the other test failures I was seeing with: cmake -G Ninja -B release-build -S llvm \ -DCMAKE_POSITION_INDEPENDENT_CODE=ON \ -DCMAKE_BUILD_TYPE=Release \ -DLLVM_ENABLE_ASSERTIONS=OFF \ -DLLVM_ENABLE_PROJECTS="clang;lld" \ -DLLVM_ENABLE_RUNTIMES="libcxx;libcxxabi;libunwind;compiler-rt" This is the same configuration the test-release.sh script uses, so I'm hoping this will also fix all the test failures we've been seeing when building the releases. Fixes #58680 (cherry picked from commit 7f215b1380da49dccbf57da3040a40d25ed898f4) Added: Modified: llvm/CMakeLists.txt Removed: ################################################################################ diff --git a/llvm/CMakeLists.txt b/llvm/CMakeLists.txt index 79de9eb2e3e71be..be0fc6c2ad76cef 100644 --- a/llvm/CMakeLists.txt +++ b/llvm/CMakeLists.txt @@ -1215,6 +1215,7 @@ if( LLVM_INCLUDE_TESTS ) add_custom_target(test-depends DEPENDS ${LLVM_ALL_LIT_DEPENDS} ${LLVM_ALL_ADDITIONAL_TEST_DEPENDS}) set_target_properties(test-depends PROPERTIES FOLDER "Tests") + add_dependencies(check-all test-depends) endif() if (LLVM_INCLUDE_DOCS) _______________________________________________ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
