Author: Louis Dionne Date: 2021-01-20T11:14:18-05:00 New Revision: 6c1bc0d24ceacfe736de4fd29a21b91125125a1f
URL: https://github.com/llvm/llvm-project/commit/6c1bc0d24ceacfe736de4fd29a21b91125125a1f DIFF: https://github.com/llvm/llvm-project/commit/6c1bc0d24ceacfe736de4fd29a21b91125125a1f.diff LOG: [docs] Fix overly specific link to uploading patches on Phabricator The documentation for contributing to LLVM currently links to the section explaining how to submit a Phabricator review using the web interface. I believe it would be better to link to the general page for using Phabricator instead, which explains how to sign up with Phabricator, and also how to submit patches using either the web interface or the command-line. I think this is worth changing because what currently *appears* to be our preferred way of submitting a patch (through the web interface) isn't actually what we prefer. Indeed, patches submitted from the command-line have more meta-data available (such as which repository the patch targets), and also can't suffer from missing context. Differential Revision: https://reviews.llvm.org/D94929 Added: Modified: llvm/docs/Contributing.rst Removed: ################################################################################ diff --git a/llvm/docs/Contributing.rst b/llvm/docs/Contributing.rst index 45d4d7a27fa7..e7fcbf36beef 100644 --- a/llvm/docs/Contributing.rst +++ b/llvm/docs/Contributing.rst @@ -90,7 +90,7 @@ in order to update the last commit with all pending changes. To get a patch accepted, it has to be reviewed by the LLVM community. This can be done using `LLVM's Phabricator`_ or the llvm-commits mailing list. -Please follow :ref:`Phabricator#requesting-a-review-via-the-web-interface <phabricator-request-review-web>` +Please follow :ref:`Phabricator#phabricator-reviews <phabricator-reviews>` to request a review using Phabricator. To make sure the right people see your patch, please select suitable reviewers _______________________________________________ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
