Author: Jay Foad Date: 2021-01-14T14:02:43Z New Revision: 90b310f6caf0b356075c70407c338b3c751eebb3
URL: https://github.com/llvm/llvm-project/commit/90b310f6caf0b356075c70407c338b3c751eebb3 DIFF: https://github.com/llvm/llvm-project/commit/90b310f6caf0b356075c70407c338b3c751eebb3.diff LOG: [Support] Simplify KnownBits::icmp helpers. NFC. Remove some special cases that aren't really any simpler than the general case. Differential Revision: https://reviews.llvm.org/D94595 Added: Modified: llvm/lib/Support/KnownBits.cpp Removed: ################################################################################ diff --git a/llvm/lib/Support/KnownBits.cpp b/llvm/lib/Support/KnownBits.cpp index 0147d21d153a..0f36c6a9ef1d 100644 --- a/llvm/lib/Support/KnownBits.cpp +++ b/llvm/lib/Support/KnownBits.cpp @@ -271,9 +271,6 @@ KnownBits KnownBits::ashr(const KnownBits &LHS, const KnownBits &RHS) { Optional<bool> KnownBits::eq(const KnownBits &LHS, const KnownBits &RHS) { if (LHS.isConstant() && RHS.isConstant()) return Optional<bool>(LHS.getConstant() == RHS.getConstant()); - if (LHS.getMaxValue().ult(RHS.getMinValue()) || - LHS.getMinValue().ugt(RHS.getMaxValue())) - return Optional<bool>(false); if (LHS.One.intersects(RHS.Zero) || RHS.One.intersects(LHS.Zero)) return Optional<bool>(false); return None; @@ -286,8 +283,6 @@ Optional<bool> KnownBits::ne(const KnownBits &LHS, const KnownBits &RHS) { } Optional<bool> KnownBits::ugt(const KnownBits &LHS, const KnownBits &RHS) { - if (LHS.isConstant() && RHS.isConstant()) - return Optional<bool>(LHS.getConstant().ugt(RHS.getConstant())); // LHS >u RHS -> false if umax(LHS) <= umax(RHS) if (LHS.getMaxValue().ule(RHS.getMinValue())) return Optional<bool>(false); @@ -312,8 +307,6 @@ Optional<bool> KnownBits::ule(const KnownBits &LHS, const KnownBits &RHS) { } Optional<bool> KnownBits::sgt(const KnownBits &LHS, const KnownBits &RHS) { - if (LHS.isConstant() && RHS.isConstant()) - return Optional<bool>(LHS.getConstant().sgt(RHS.getConstant())); // LHS >s RHS -> false if smax(LHS) <= smax(RHS) if (LHS.getSignedMaxValue().sle(RHS.getSignedMinValue())) return Optional<bool>(false); _______________________________________________ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
