Author: Nico Weber Date: 2020-12-03T09:00:10-05:00 New Revision: 68f2ff59d114a5511e197472d2d4f23fea7ff0f5
URL: https://github.com/llvm/llvm-project/commit/68f2ff59d114a5511e197472d2d4f23fea7ff0f5 DIFF: https://github.com/llvm/llvm-project/commit/68f2ff59d114a5511e197472d2d4f23fea7ff0f5.diff LOG: clang/darwin: Don't use response files with ld64 This morally reverts D82777 -- turns out that ld64 crashes with many response files, so we must stop passing them to it until the crash is fixed. Differential Revision: https://reviews.llvm.org/D92357 Added: Modified: clang/lib/Driver/ToolChains/Darwin.cpp Removed: ################################################################################ diff --git a/clang/lib/Driver/ToolChains/Darwin.cpp b/clang/lib/Driver/ToolChains/Darwin.cpp index f1846a573914..9f8560356405 100644 --- a/clang/lib/Driver/ToolChains/Darwin.cpp +++ b/clang/lib/Driver/ToolChains/Darwin.cpp @@ -698,7 +698,10 @@ void darwin::Linker::ConstructJob(Compilation &C, const JobAction &JA, } ResponseFileSupport ResponseSupport; - if (Version[0] >= 607 || LinkerIsLLDDarwinNew) { + if (LinkerIsLLDDarwinNew) { + // Xcode12's ld64 added support for @response files, but it's crashy: + // https://openradar.appspot.com/radar?id=4933317065441280 + // FIXME: Pass this for ld64 once it no longer crashes. ResponseSupport = ResponseFileSupport::AtFileUTF8(); } else { // For older versions of the linker, use the legacy filelist method instead. _______________________________________________ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
