Author: Sam Clegg Date: 2020-12-01T14:53:59-08:00 New Revision: a38ed62ea803a41c2e1f3fa12edbc176e474056f
URL: https://github.com/llvm/llvm-project/commit/a38ed62ea803a41c2e1f3fa12edbc176e474056f DIFF: https://github.com/llvm/llvm-project/commit/a38ed62ea803a41c2e1f3fa12edbc176e474056f.diff LOG: [lld][WebAssembly] Feedback from D92038. NFC Differential Revision: https://reviews.llvm.org/D92429 Added: Modified: lld/test/wasm/weak-undefined-pic.s lld/wasm/Symbols.h Removed: ################################################################################ diff --git a/lld/test/wasm/weak-undefined-pic.s b/lld/test/wasm/weak-undefined-pic.s index c12ef235d85f..a169fd315f08 100644 --- a/lld/test/wasm/weak-undefined-pic.s +++ b/lld/test/wasm/weak-undefined-pic.s @@ -27,7 +27,7 @@ _start: .weak foo .functype foo () -> (i32) -# Verify that we do not generate dynamnic relocations for the GOT entry. +# Verify that we do not generate dynamic relocations for the GOT entry. # CHECK-NOT: __wasm_apply_relocs @@ -68,7 +68,7 @@ _start: # CHECK-NEXT: - Index: 1 # CHECK-NEXT: Name: 'undefined_weak:foo' -# With `-pie` or `-shared` the resolution should is defered to the dynamic +# With `-pie` or `-shared` the resolution should be deferred to the dynamic # linker and the function address should be imported as GOT.func.foo. # # RUN: wasm-ld --experimental-pic -pie %t.o -o %t3.wasm diff --git a/lld/wasm/Symbols.h b/lld/wasm/Symbols.h index 90fb5194edcd..cfa686998de4 100644 --- a/lld/wasm/Symbols.h +++ b/lld/wasm/Symbols.h @@ -160,6 +160,9 @@ class Symbol { // True if this symbol is a linker-synthesized stub function (traps when // called) and should otherwise be treated as missing/undefined. See // SymbolTable::replaceWithUndefined. + // These stubs never appear in the table and any table index relocations + // against them will produce address 0 (The table index representing + // the null function pointer). bool isStub : 1; uint32_t flags; _______________________________________________ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
