On 19 Feb 2021, at 19:14, Tom Stellard <tstel...@redhat.com> wrote: > > On 2/13/21 1:44 PM, Louis Dionne wrote: >>> On Feb 13, 2021, at 12:04, Dimitry Andric <dimi...@andric.com> wrote: >>> On 28 Jan 2021, at 05:05, Tom Stellard via llvm-dev >>> <llvm-...@lists.llvm.org> wrote: >>>> >>>> I've tagged the 12.0.0-rc1 release. Testers can begin testing and upload >>>> binaries. >>> >>> During 12.0.0-rc1 test builds on FreeBSD, I encountered this unittest >>> failure, which turned out to be caused by recent libc++ changes: ... >>> If you think this is a reasonable approach, I will create a review for it. >>> Otherwise, I will have to patch the test-release.sh script to pass >>> -DLIBCXX_ENABLE_NEW_DELETE_DEFINITIONS=ON to the CMake command line on >>> FreeBSD. >> The correct approach would be to have a CMake cache file under >> libcxx/cmake/cache/FreeBSD.cmake that sets the right configuration for >> building libcxx as a system library on freebsd. That way, the cmake code >> itself can stay free of platform specific logic. >> Also note that I remember asking vendors before making that change, but I >> guess I either forgot to ask Freebsd or you told me OK without thinking >> about this. I can’t verify which one happened because I’m on my phone, but >> I’ll check it out to make sure I have your contact information if I need to >> ask that sort of questions in the future. It could be useful to have some >> sort of libcxx-vendors group in Phabricator that I could tag whenever I want >> to ping you folks. >> Please send a Phab and I’ll revise it quickly (probably on Monday morning). > > Has this been fixed in the branch yet?
Yes, I submitted https://bugs.llvm.org/show_bug.cgi?id=49197, and you merged the fix in d14016d869ac. Thanks! :) (That said, more work should probably be done on this particular issue, but the merged fix is good enough for the release.) -Dimitry
signature.asc
Description: Message signed with OpenPGP
_______________________________________________ lldb-dev mailing list lldb-dev@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev
