Hi,
Is this monotonic incrementing identifier part of the email? I think
it would really complicate buildbot maintenance if we didn't have it
in obvious places. For instance, we have a (hacky) monitoring page for
our ARM/AArch64 buildbots [1] and it really helps a lot to just look
at the commit range for the last build to know if a fix actually
worked or not ("is the fix commit in that range? if not wait a bit
more before investigating"). Using just a git hash and having to
manually count commits would be a waste of time.
Just my 2c,
Diana
[1] http://llvm.validation.linaro.org/
On Wed, 16 Oct 2019 at 07:42, Shoaib Meenai via llvm-dev
<[email protected]> wrote:
>
> I thought we were just going to count commits on a particular branch and use
> the (branch name, commit count) tuple as our monotonic incrementing
> identifier?
> https://llvm.org/docs/Proposals/GitHubMove.html#on-managing-revision-numbers-with-git
>
>
>
>
>
> From: cfe-dev <[email protected]> on behalf of cfe-dev
> <[email protected]>
> Organization: Red Hat
> Reply-To: "[email protected]" <[email protected]>
> Date: Tuesday, October 15, 2019 at 10:13 PM
> To: Mehdi AMINI <[email protected]>
> Cc: llvm-dev <[email protected]>, cfe-dev <[email protected]>,
> "openmp-dev ([email protected])" <[email protected]>, LLDB
> Dev <[email protected]>
> Subject: Re: [cfe-dev] Mailing list changes this week
>
>
>
> On 10/15/2019 09:44 PM, Mehdi AMINI wrote:
>
> On Tue, Oct 15, 2019 at 9:33 PM Tom Stellard <[email protected]
> <mailto:[email protected]>> wrote:
>
> On 10/15/2019 09:24 PM, Mehdi AMINI wrote:
>
> > Hi Tom.
>
> >
>
> > One issue with this is that we don't have a clear "ordering" from
> linear revision numbers from these emails. Have we looked into continuing to
> generate our own emails per commits instead so that we control the format?
>
> >
>
> This actually what we are doing, we are listening for github commit
> events and
>
> then generating our own emails based on the data in the event. We can
> format
>
> the emails how ever we want, and we tried to match the current SVN
> format exactly.
>
> Ah great!
>
>
>
> Is the some other information you would like to have in the emails to
> show the
>
> ordering?
>
> The only thing I was looking to get was to continue to have a monotonic
> incrementing integer for the revision instead of the git hash alone: I don't
> know if `git llvm` has this feature yet but this was discussed a while ago (I
> don't remember if we just mentioned counting the commits in the repo from the
> beginning or using an invocation of `git describe` or something derived).
>
>
>
> We talked about using `git describe` for this, but this would require that we
>
> add tags to the master branch each time the version number was bumped. We
>
> discussed this[1] last year, but deferred the decision, since we couldn't get
>
> consensus on the tag name.
>
>
>
> -Tom
>
>
>
> [1]
> https://urldefense.proofpoint.com/v2/url?u=http-3A__lists.llvm.org_pipermail_llvm-2Ddev_2018-2DDecember_128484.html&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=_SmpuqSzuAhMoF3exJmWRp6KnerIOE6WdU4kcv3tjhQ&s=p_75z-WV3dFcBRoqs2YeTexKxeCf8oyS-atIo6wG6Fg&e=
>
>
>
> --
>
> Mehdi
>
>
>
> -Tom
>
> > Thanks,
>
> >
>
> > --
>
> > Mehdi
>
> >
>
> >
>
> >
>
> > On Tue, Oct 15, 2019 at 9:07 PM Tom Stellard via cfe-dev
> <[email protected] <mailto:[email protected]>
> <mailto:[email protected] <mailto:[email protected]>>> wrote:
>
> >
>
> > Hi,
>
> >
>
> > We are going to start to switching from SVN commit emails to
> GitHub commit
>
> > emails this week. The only real change you should notice is that
>
> > the revision number in the subject will be replaced with a git
> hash and
>
> > the diff links in the email will point to GitHub. Otherwise the
>
> > content and format of the email should be the same.
>
> >
>
> > We are going to start by rolling this out for the openmp-commits
> list
>
> > and then once that's working begin migrating the rest of the
> lists. If you
>
> > notice any issues with the new emails, please file a bug and mark
> it
>
> > as a blocker of the github meta-bug (llvm.org/PR39393
> <https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_PR39393&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=_SmpuqSzuAhMoF3exJmWRp6KnerIOE6WdU4kcv3tjhQ&s=eX8PTSE7QycIi5KeESJj4VzteOcs9k7RANSWPgiiQ2Q&e=
> >
> <https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_PR39393&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=_SmpuqSzuAhMoF3exJmWRp6KnerIOE6WdU4kcv3tjhQ&s=eX8PTSE7QycIi5KeESJj4VzteOcs9k7RANSWPgiiQ2Q&e=
> >).
>
> >
>
> > Thanks,
>
> > Tom
>
> > _______________________________________________
>
> > cfe-dev mailing list
>
> > [email protected] <mailto:[email protected]>
> <mailto:[email protected] <mailto:[email protected]>>
>
> >
> https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.llvm.org_cgi-2Dbin_mailman_listinfo_cfe-2Ddev&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=_SmpuqSzuAhMoF3exJmWRp6KnerIOE6WdU4kcv3tjhQ&s=xRFk9gEi6pLejTNAvlPR6gtikLoWNgyvL7b-TAvUcnc&e=
>
> >
>
>
>
> _______________________________________________
>
> cfe-dev mailing list
>
> [email protected]
>
> https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.llvm.org_cgi-2Dbin_mailman_listinfo_cfe-2Ddev&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=_SmpuqSzuAhMoF3exJmWRp6KnerIOE6WdU4kcv3tjhQ&s=xRFk9gEi6pLejTNAvlPR6gtikLoWNgyvL7b-TAvUcnc&e=
>
>
>
> _______________________________________________
> LLVM Developers mailing list
> [email protected]
> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
_______________________________________________
lldb-dev mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev
