On Thu, 10 Oct 2019, Mehdi AMINI wrote:
On Thu, Oct 10, 2019 at 12:02 PM Martin Storsjö <mar...@martin.st> wrote:
On Thu, 10 Oct 2019, Tom Stellard via cfe-dev wrote:
> On 10/09/2019 11:05 PM, Mehdi AMINI wrote:
>>
>>
>> On Wed, Oct 9, 2019 at 10:16 PM Tom Stellard via cfe-dev
<cfe-...@lists.llvm.org <mailto:cfe-...@lists.llvm.org>> wrote:
>
> I haven't been able to find a way to restrict branch creation
for committers,
> I'm not sure if this is even possible.
>
> We could try to enforce this rule in the git-llvm script, but
this would
> mean making use of the script mandatory, which was our
original plan, but
> that was based on the assumption that the "Require Linear
History"
> protection would not be ready in time.
>
> Generally, would it be better if we kept use of the script
mandatory so that
> we can handle this and other potential restrictions in the
future?
Personally, I'd prefer to avoid requiring a custom tool for
pushing
commits, if possible.
As for creating undesired branches; contrary to accidentally
pushing merge
commits on the master branch, any accidentally created branch
should be
possible to remove without any permanent traces left behind
(especially as
it doesn't affect the master branch). So for that purpose alone,
I'd vote
for not requiring git-llvm for pushing.
The original reason for the tool is about linear history (contrary to
branches, this can't be undone).
Yes, I see (or saw) the reason for the tool if a linear history couldn't
be guaranteed otherwise, but I'm more hesitant if the only current purpose
is preventing branch creation.
Btw, out of curiousity, what mechanism does GitHub offer for
verifying
that the push actually comes from git-llvm? (I'm sorry if this
part was
discussed elsewhere, but I don't remember seeing it discussed
lately.)
I mentioned it on LLVM-dev a couple of times a while back (here for example:
http://lists.llvm.org/pipermail/llvm-dev/2019-February/129896.html )
But apparently the concrete implementation was discussed on cfe-dev@ only,
so here are the details:
http://lists.llvm.org/pipermail/cfe-dev/2019-April/062063.html
Ok, thanks for the references! That's a rather interesting feature they
have.
// Martin
_______________________________________________
lldb-dev mailing list
lldb-dev@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev
