Hey Stefan, > On Jul 3, 2019, at 3:29 PM, Stefan Gränitz <sgraen...@apple.com> wrote: > > Hey Jonas, thanks for the initiative! I actually started doing the same today > but then go distracted. Your changes certainly put it in a much better shape! > Before touching anything again, maybe it's worth some feedback first: > > * In "Building LLDB with CMake & Ninja": Should we update the build > instructions for the monorepo?
I was thinking about this myself. I believe it's part of the LLVM getting started page, which we link initially. On the other hand, it might be good to point out that you need libcxx on macOS. I'll leave the decision up to you. > > * In "Building LLDB with CMake and Other Generators": Using an IDE generator > for all of LLDB/LLVM/Clang/libc++ results in a huge workspace that is not > really manageable anymore (at least in Xcode). Do you think it's worth > explaining here that we can generate the IDE workspace for standalone LLDB > and have the dependencies in a provided Ninja build-tree? Yep, definitely! I was going to ask you to complete this section as you've been working on this. > > * Either as another section or (maybe for now) as a note in the existing > per-OS sections, I would explain how to use the CMake caches. I think that > could be useful with the above two proposals. Sounds good! > > What do you think? > I will rebase my current state on yours on Monday and then submit a proposal > during the week. Thanks! > > Best > Stefan > >> On 3. Jul 2019, at 22:51, Jonas Devlieghere via Phabricator >> <revi...@reviews.llvm.org> wrote: >> >> JDevlieghere closed this revision. >> JDevlieghere added a comment. >> >> Landed in rL365081 <https://reviews.llvm.org/rL365081> >> >> >> CHANGES SINCE LAST ACTION >> https://reviews.llvm.org/D64154/new/ >> >> https://reviews.llvm.org/D64154 >> >> >> > _______________________________________________ lldb-dev mailing list lldb-dev@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev
