On 25 Aug 2018, at 00:51, Hans Wennborg <h...@chromium.org> wrote: > > On Wed, Aug 22, 2018 at 10:33 PM, Dimitry Andric <dimi...@andric.com> wrote: >> On 22 Aug 2018, at 18:45, Hans Wennborg <h...@chromium.org> wrote: >>> >>> On Wed, Aug 22, 2018 at 3:48 AM, Dimitry Andric <dimi...@andric.com> wrote: >>>> On 22 Aug 2018, at 05:58, Wei Mi <w...@google.com> wrote: ... >>>>> Sorry I missed the thread for quite a while. Dimitry, I am very confused >>>>> because you reported the issue in >>>>> https://bugs.llvm.org/show_bug.cgi?id=34347#c6, so you want r323281 to be >>>>> reverted and let llvm to generate cmxchg8b instruction for i486? >>>> >>>> Since it's been doing this for a number of years now, I don't think it >>>> would be bad at all, at least not for FreeBSD. At least, a lot more >>>> effort is needed to supply properly working atomic libcalls for 64 bit >>>> values on i386. (They can't be implemented without at least a bit of >>>> kernel assistance.) >>> >>> According to the release schedule we should tag RC2 today. Do you >>> think there's any chance of getting this figured out by today? >> >> Since I'm testing on FreeBSD 11.x, and that will take quite a while to get >> any new changes, I'd say it's safer to revert for now, at least on the >> branch. At least then I can build and test the RCs on i386-freebsd. :) > > I've reverted on trunk in r340666 and merged to the 7.0 branch in > r340667. Also +Craig fyi for X86. > > Unfortunately this happened after RC2 which was tagged yesterday, but > perhaps you can do a test run against the tip of the branch, and then > later RC3 of coures? > > Also, is there a bug filed somewhere to track fixing the FreeBSD side? > It would be great if we could reinstate this patch again before the > next release.
I've now filed <https://bugs.freebsd.org/230888>. -Dimitry
signature.asc
Description: Message signed with OpenPGP
_______________________________________________ lldb-dev mailing list lldb-dev@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev
