On 2 January 2018 at 19:20, Jim Ingham <jing...@apple.com> wrote: > This is actually using the same mechanism that Greg was describing, but > through a separate route. > > With the crashinfo mechanism in place, if a test crashes the crash log will > show whatever test was being run at the time of the crash. This was pretty > useful when we were running the testsuite in one process, since then it was > pretty hard to figure out where the test crashed. But now that the runner is > in a separate process it doesn't go down when a test crashes, so you can tell > at the least which test directory caused the crash. If we want to make this > better we could do something more platform independent to track which test in > a particular directory is the current test, and then report that when we see > a crash. But I don't think it is worth much effort keeping the current > mechanism alive.
I agree with that. I have created D41871 to delete the hook. Also, note that the current test runner will already report the full test case name if we have a crash (except if the crash happens after the relevant tearDown method finishes, but in that case, the crashinfo hook would not help either). _______________________________________________ lldb-dev mailing list lldb-dev@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev
