[lldb-dev] Unifying ctor+Clear() inits into in-class initializers?

[Jan Kratochvil via lldb-dev]

Hi,

https://reviews.llvm.org/D40212

At least DWARFCompileUnit and I see even for example MachVMRegion duplicate
intialization of fields in both their constructor and Clear().  Moreover the
initialization is in different place than declaration of the member variable.

Is it OK to just use in-class member variable initializers and:
        void Clear() {
          this->~ClassName();
          new (this) ClassName();
        }
?

Pavel Labath otherwise suggests to just call Clear() from the constructor.
Still then I find the code could be more readable with in-class members
initializers - moreover during further refactorizations+extensions.


Thanks,
Jan Kratochvil
_______________________________________________
lldb-dev mailing list
lldb-dev@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev