To be frank, I do not like that either. I could add the test the DWARF emission feature hit OCaml packages.
Anyway, here are the patches. I would be fine with just the code review if the absence of tests is a bother. I ran check-lldb before and after applying the patches, and AFAIK I didn't introduce any regressions. Elias From: tbergham...@google.com Date: Thu, 7 Jul 2016 13:23:41 +0000 Subject: Re: [lldb-dev] Add support for OCaml native debugging To: e.bouta...@hotmail.fr; lldb-dev@lists.llvm.org What type of binaries do you want to commit in? Generally we don't like putting binaries to the repository because they are not human readable so it is hard to review/diff them and they will only run on a single platform and a single architecture while we support a lot of different configuration. Tamas On Wed, Jul 6, 2016 at 3:26 PM E BOUTALEB via lldb-dev <lldb-dev@lists.llvm.org> wrote: I would like to submit two patches for code review. They introduce concrete support for OCaml native debugging, granted that you have access to the native compiler with DWARF emission support (see https://github.com/ocaml/ocaml/pull/574) This adds about 2000 lines of code. The type system isn't particularly complex here, every value is considered as an unsigned integer, and interpretation of the value is left to an external debugging layer made in OCaml. The language plugin handles function name demangling for breakpoints too. No tests for now. Is it fine to commit binaries with the patchs? Elias Boutaleb _______________________________________________ lldb-dev mailing list lldb-dev@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev
0002-Demangling-OCaml-function-symbols.patch
Description: Binary data
0001-Add-support-for-OCaml-native-debugging.patch
Description: Binary data
_______________________________________________ lldb-dev mailing list lldb-dev@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev
