I did not see hear any complain about this patch from Deepak. So I think it is OK on MSVC. I will apply it now.
Thanks, Abid > -----Original Message----- > From: Greg Clayton [mailto:[email protected]] > Sent: 11 March 2014 17:01 > To: Abid, Hafiz > Cc: [email protected]; Deepak Panickal <[email protected]> > ([email protected]) > Subject: Re: [lldb-dev] [patch] Change a few struct members from unsigned > to signed > > Looks ok as long as people that use MSVC agree it works fine. > > On Mar 11, 2014, at 5:07 AM, Abid, Hafiz <[email protected]> wrote: > > > Hi, > > This patches changes the type of 2 struct members from unsigned to > signed. They are used respectively in InterlockedIncrement and in > InterlockedExchange respectively which seem to take a signed argument. > > http://msdn.microsoft.com/en- > us/library/windows/desktop/ms683614%28v=v > > s.85%29.aspx > > http://msdn.microsoft.com/en- > us/library/windows/desktop/ms683590%28v=v > > s.85%29.aspx > > > > Deepak, > > Please let me know if it causes any problem with MSVC++. > > > > Thanks, > > Abid > > > > > > > <signed_type.patch>_______________________________________________ > > lldb-dev mailing list > > [email protected] > > http://lists.cs.uiuc.edu/mailman/listinfo/lldb-dev _______________________________________________ lldb-dev mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/lldb-dev
