Abid, Dmitry, and everyone else: I'm still working on this patch. It turns out the Clang changes break a few things (e.g., namespaces) and I'm working with Richard Smith and Doug Gregor to iron things out. If I don't have a good, working patch today then I'll commit something so people can build at least. Sorry for the sucky weekend.
Sean On Feb 8, 2013, at 9:52 AM, Sean Callanan <[email protected]> wrote: > No, simply returning BOOL is not sufficient (because then no results would be > reported). I have talked to the Clang folks about this and I'll get a patch > in this morning. > > Sean > > On Feb 8, 2013, at 9:33 AM, "Abid, Hafiz" <[email protected]> wrote: > >> I am new to lldb so I am not sure what the correct fix is? If the base class >> will stay the same then we can modify the derived to return bool also. If >> that sounds like a correct solution then I can prepare a patch. >> >> Thanks, >> Abid >> ________________________________________ >> From: Dmitry Markman [[email protected]] >> Sent: Friday, February 08, 2013 5:19 PM >> To: Abid, Hafiz >> Cc: Dmitry Markman; [email protected] >> Subject: Re: [lldb-dev] compiler error with building lldb from scratch >> >> thanks Abid >> >> did you submit the fix? >> >> >> >> On Feb 8, 2013, at 12:17 PM, "Abid, Hafiz" <[email protected]> wrote: >> >>> This seems to be caused by the following commit. >>> >>> ------------------------------------------------------------------------ >>> r174576 | rsmith | 2013-02-07 03:30:24 +0000 (Thu, 07 Feb 2013) | 9 lines >>> >>> Simplify FindExternalVisibleDeclsByName by making it return a bool >>> indicating >>> if it found any decls, rather than returning a list of found decls. This >>> removes a returning-ArrayRef-to-deleted-storage bug from >>> MultiplexExternalSemaSource (in code not exercised by any of the clang >>> binaries), reduces the work required in the found-no-decls case with PCH, >>> and >>> importantly removes the need for DeclContext::lookup to be reentrant. >>> >>> >>> Regards, >>> Abid >>> ________________________________________ >>> From: [email protected] [[email protected]] on behalf >>> of Dmitry Markman [[email protected]] >>> Sent: Friday, February 08, 2013 2:07 PM >>> To: [email protected] >>> Subject: [lldb-dev] compiler error with building lldb from scratch >>> >>> I just checked out lldb sources, open Xcode workspace >>> in attempt to build lldb-tool target >>> >>> I got few errors like >>> virtual function 'FindExternalVisibleDeclsByName' has a different return >>> type ('clang::DeclContextLookupResult' (aka >>> 'MutableArrayRef<clang::NamedDecl *>')) than the function it overrides >>> (which has return type 'bool') >>> FindExternalVisibleDeclsByName (const clang::DeclContext *DC, >>> >>> and indeed file >>> lldb/llvm/tools/clang/include/clang/AST/ExternalASTSource.h has the >>> following declaration >>> virtual bool >>> FindExternalVisibleDeclsByName(const DeclContext *DC, DeclarationName Name); >>> >>> >>> but my llvm sources (173760) >>> has the following declaration >>> >>> virtual DeclContextLookupResult >>> FindExternalVisibleDeclsByName(const DeclContext *DC, DeclarationName Name); >>> >>> >>> if I replace lldb/llvm folder with llvm folder (173760) >>> >>> I got another error: >>> lldb/source/DataFormatters/CXXFormatterFunctions.cpp:14:10: fatal error: >>> 'llvm/Support/ConvertUTF.h' file not found >>> >>> >>> that file does exist in the latest llvm repository >>> so if I copy that file to the lldb/llvm/include/llvm/Support folder >>> >>> then build was ok >>> >>> thanks >>> >>> >>> >>> Dmitry Markman >>> >>> _______________________________________________ >>> lldb-dev mailing list >>> [email protected] >>> http://lists.cs.uiuc.edu/mailman/listinfo/lldb-dev >> >> Dmitry Markman >> >> >> _______________________________________________ >> lldb-dev mailing list >> [email protected] >> http://lists.cs.uiuc.edu/mailman/listinfo/lldb-dev > _______________________________________________ lldb-dev mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/lldb-dev
