Michael137 wrote: > > The test will fail on windows because no_unique_address is not a thing > > there: > > Seems like that we should spell it as `[[msvc::no_unique_address]]` on > Windows. Is there already such a macro in lldb/test covering this?
Don't think we have coverage for the `[[msvc::no_unique_address]]`. I'm not sure whether this attribute affects PDB (or DWARF for that matter) in the same way that `[[no_unique_address]]` does. And I don't have the setup to test this unfortunately. So I'd rather add a triple explicitly like Pavel suggested, since that exercises exactly the failing codepath that I saw. https://github.com/llvm/llvm-project/pull/108155 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
