https://github.com/labath commented:

I am worried about the thread safety aspects of this, in particular for these 
"long term storage" errors. I don't know if we have any users like this, but I 
think it wouldn't be unreasonable for someone to expect that they can access 
these errors from multiple threads (concurrently). I'm not sure if the current 
implementation is safe in this respect, but I suspect it isn't because of the 
fiddling with the "checked" flag that the Error class does. If it is a problem, 
one way around it might be to store the Error in a "deconstructed" form -- as a 
list of ErrorInfoBase objects...

https://github.com/llvm/llvm-project/pull/106774
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to