================
@@ -285,7 +285,7 @@ class ModuleList {
   /// \see Module::FindFunctions ()
   void FindFunctions(ConstString name, lldb::FunctionNameType name_type_mask,
                      const ModuleFunctionSearchOptions &options,
-                     SymbolContextList &sc_list) const;
+                     const SymbolContext &sc, SymbolContextList &sc_list) 
const;
----------------
clayborg wrote:

We might be able to reduce the number of changes in the codebase if we add the 
symbol context at the end and make it a pointer. If the pointer is NULL, then 
no context matching will occur, else it will try to use the `sc->module_sp`. It 
will help reduce the changes in our codebase and having a pointer might help 
indicate that the symbol context is optional.

Maybe we do:
```

void FindFunctions(ConstString name, lldb::FunctionNameType name_type_mask,
                     const ModuleFunctionSearchOptions &options,
                     SymbolContextList &sc_list, const SymbolContext *sc = 
nullptr) const;

https://github.com/llvm/llvm-project/pull/102835
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to