https://github.com/labath commented:
> @labath I have added the class SharedSocket. I have implemented all the > recommendations. Looks mostly fine. Just a couple of notes. David, what do you think? > Note we have the buildbot for cross tests (Windows x64/Linux x64 host and > Linux Aarch64 target). > So everything is tested. Hope 1191 API tests run with this lldb-server are > enough. That's great, but I don't think this should be the only way this code is tested, as most of it can be tested perfectly well locally. Most of the devs will not be running this bot configuration before they push their patches, and they will not know how to set it up when they get the breakage email, so it's always better to have a first line of defense that everyone can use, and leave the cross testing for catching subtle integration details. That said, we do have that one test which should exercise most of this code, so I'm sort of fine with this for now, but I still may ask for more tests in the future, for example, when we librarize this code. https://github.com/llvm/llvm-project/pull/101283 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
