https://github.com/jimingham approved this pull request.
This looks fine. I'd add a using TimeoutInfoSP = std::shared_ptr<...> and refer to it that way. The construct appears enough times to warrant that; it's a lot easier to read and we use the SP suffix consistently so it will be understood. But that's a matter of taste. https://github.com/llvm/llvm-project/pull/102208 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits