dlav-sc wrote:

> I put up a PR that avoids a memory region starting at address 0, and also 
> clarifies the documentation of the qMemoryRegionInfo packet to state that 
> permissions: are required for all memory regions that are accessible by the 
> inferior process. A memory region with no `permissions:` key means that it is 
> not an accessible region of memory. I put this PR up at #100288 @dlav-sc what 
> do you think? I know you've moved past this issue by implementing 
> memory-allocation and fixing your qMemoryRegionInfo packet response, but I 
> wanted to get a final fix before we all walk away from this PR.

I've checked your patch on my machine and it works, so looks good to me.

 >I've merged https://github.com/llvm/llvm-project/pull/100288 I think we 
 >should close this PR.

Yep, lets close this PR.

https://github.com/llvm/llvm-project/pull/99045
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to