================ @@ -32,12 +33,24 @@ class SaveCoreOptions { void SetOutputFile(lldb_private::FileSpec file); const std::optional<lldb_private::FileSpec> GetOutputFile() const; + Status SetProcess(lldb::ProcessSP process_sp); + + Status AddThread(lldb_private::Thread *thread); + bool RemoveThread(lldb_private::Thread *thread); + bool ShouldSaveThread(lldb::tid_t tid) const; + + Status EnsureValidConfiguration(lldb::ProcessSP process_to_save) const; + void Clear(); private: + void ClearProcessSpecificData(); + std::optional<std::string> m_plugin_name; std::optional<lldb_private::FileSpec> m_file; std::optional<lldb::SaveCoreStyle> m_style; + std::optional<lldb::ProcessSP> m_process_sp; ---------------- clayborg wrote:
This is a shared pointer, it being NULL is enough to say that there is no process set. Switch this to just a `ProcessSP m_process_sp;` https://github.com/llvm/llvm-project/pull/100443 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits