https://github.com/medismailben commented:

This is very interesting, I've left a few comments here and there but I've 
noticed you didn't check if this works both when the debugger is in synchronous 
and asynchronous in your tests. This is definitely something you want to 
exercise since it changes lldb's execution control behavior.

Also, I'm not sure what additional information does the `History Boundary` stop 
reason provides. Can it actually provide historical data to the user ? If so, 
I'm not sure the stop reason is the best place to put it. May be it would be 
worth adding a new subcommand to [the trace top-level 
command](https://github.com/llvm/llvm-project/blob/main/lldb/source/Commands/CommandObjectTrace.cpp#L379)
 ?

Thanks!

https://github.com/llvm/llvm-project/pull/99736
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to