================
@@ -6519,14 +6519,16 @@ struct page_object {
};
bool ObjectFileMachO::SaveCore(const lldb::ProcessSP &process_sp,
- const FileSpec &outfile,
- lldb::SaveCoreStyle &core_style, Status &error)
{
- if (!process_sp)
- return false;
-
- // Default on macOS is to create a dirty-memory-only corefile.
+ const lldb_private::CoreDumpOptions &options,
+ Status &error) {
+ auto core_style = options.GetStyle();
if (core_style == SaveCoreStyle::eSaveCoreUnspecified)
core_style = SaveCoreStyle::eSaveCoreDirtyOnly;
+ // The FileSpec is already checked in PluginManager::SaveCore.
+ assert(options.GetOutputFile().has_value());
+ const FileSpec outfile = options.GetOutputFile().value();
+ if (!process_sp)
+ return false;
----------------
clayborg wrote:
This would be checked in the `PluginManager::SaveCore(...)` and we can do a
assert like we did for the options.GetOutputFile() above
https://github.com/llvm/llvm-project/pull/98403
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
