medismailben wrote:

> The one thing I was uncertain of is when I load kexts -- I have a known 
> number of kexts that I will be attempting to load -- and I wasn't sure if I 
> should log them individually as they happen (what I did), or if I should 
> initialize a progress category with the number of kexts that lldb will be 
> attempting to load, so the progress of the job overall can be visualized.

If we know ahead of time how many kext will be loaded, I think it would be 
better to provide that number to the progress object constructor, and pass the 
name of the kext (and other relevant information) in the [`Increment` 
upgraded_details string 
argument](https://github.com/llvm/llvm-project/blob/main/lldb/include/lldb/Core/Progress.h#L104).
 Otherwise this is great! LGTM!

https://github.com/llvm/llvm-project/pull/98845
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to