================ @@ -222,6 +232,148 @@ struct ForkLaunchInfo { // End of code running in the child process. +#if defined(__QNX__) +static ::pid_t PosixSpawn(const ForkLaunchInfo &info, ---------------- labath wrote:
This is basically reimplementing `LaunchProcessPosixSpawn` inside `ProcessLauncherPosixFork.cpp`. Instead of shoehorning the `posix_spawn` implementation into ProcessLauncherPosix**Fork** (I assume you're doing this because your os doesn't support `fork`), it would be better to create a separate ProcessLauncher subclass for that. If there are things that can be meaningfully shared between the two implementations, they can go into a separate base class (but I expect that there's more sharing potential with the aforementioned (currently, mac-specific) `LaunchProcessPosixSpawn` implementation. https://github.com/llvm/llvm-project/pull/97630 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits